Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of ~/.overmind.env seems broken #98

Closed
ianmalott opened this issue Oct 5, 2020 · 0 comments · Fixed by #99
Closed

Loading of ~/.overmind.env seems broken #98

ianmalott opened this issue Oct 5, 2020 · 0 comments · Fixed by #99

Comments

@ianmalott
Copy link
Contributor

Per the environment section of the README, I'd expect to be able to set env vars via ~/.overmind.env for global config across projects. I've found that I can set env vars via ./.overmind.env for project-specific config. In main.go, it looks like the issue may be the expectation of shell-like expansion of "~" to a home dir path.

https://github.com/DarthSim/overmind/blob/master/main.go#L196-L197:

	godotenv.Overload("~/.overmind.env")
	godotenv.Overload("./.overmind.env")

It doesn't look like the underlying os.Open will do that, though. Instead, I think os.UserHomeDir could do the trick. I'll submit a PR shortly.

By the way, thanks for building this clever tool. I've used foreman, heroku local, and most recently tmux to work around their shortcomings, but that has meant stepping away from the Procfile. This seems like a much more promising solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant