Prevent accidental creation of lexical closures.

Fixes jwiegley#17. (Try async-test-7)
DarwinAwardWinner · Oct 17, 2013 · 8e05e02 · 8e05e02 · thierryvolpiatto · Oct 17, 2013
1 parent 9c02acd
commit 8e05e02
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/async.el b/async.el
@@ -260,8 +260,11 @@ passed to FINISH-FUNC).  Call `async-get' on such a future always
 returns nil.  It can still be useful, however, as an argument to
 `async-ready' or `async-wait'."
   (require 'find-func)
-  (let ((procvar (make-symbol "proc")))
+  (let ((procvar (make-symbol "proc"))
-    `(let* ((sexp ,start-func)
+        ;; Avoid accidental lexical closures by evaluating START-FUNC
+        ;; in an empty lexical environment.
+        (start-func (eval start-func t)))
+    `(let* ((sexp #',start-func)
             (,procvar
              (async-start-process
               "emacs" (file-truename