Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion-auto-help not respected #172

Closed
wyuenho opened this issue May 16, 2020 · 6 comments
Closed

completion-auto-help not respected #172

wyuenho opened this issue May 16, 2020 · 6 comments

Comments

@wyuenho
Copy link

wyuenho commented May 16, 2020

The minibuffer has a custom option called completion-auto-help, which prevents the minibuffer help buffer from popping up when tabbing on an empty input. When ido-ubiquitous-mode is enabled.

Reproduction:

  1. (setq icomplete-mode t)
  2. (setq completion-auto-help nil)
  3. (ido-ubiquitous-mode t)
  4. M-x describe-function RET TAB
  5. The minibuffer help buffer pops up.

Expectation:
No minibuffer help buffer pops up

@DarwinAwardWinner
Copy link
Owner

Can you tell me if the following works for you? If so, I'll incorporate a version of it into the next ido-cr+ release.

(define-advice ido-completion-help (:around (orig-fun &rest args) respect-completion-auto-help)
  "Don't show *Ido Completions* buffer when `completion-auto-help' is nil."
  (when completion-auto-help
    (apply orig-fun args)))

@DarwinAwardWinner
Copy link
Owner

Note that ido has its own setting, ido-cannot-complete-command, which you can set to ignore to achieve a similar effect. Ultimately, to the extent that this is a bug, it is a bug in ido itself. Hence, I've reported it to the Emacs bug tracker: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41340

@wyuenho
Copy link
Author

wyuenho commented May 18, 2020

That snippet doesn't work. The help buffer should still pop up after pressing ? when completion-auto-help is nil. There's also no reliable way to ignore appropriately because ido-completion-help is called interactively from ido-complete.

@DarwinAwardWinner
Copy link
Owner

Does setting ido-cannot-complete-command to ignore do what you want?

@wyuenho
Copy link
Author

wyuenho commented May 19, 2020

Yep that does it. Thanks!

@DarwinAwardWinner
Copy link
Owner

Closing this as it will be addressed in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants