New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker for backend use #1
Conversation
backend/package.json
Outdated
@@ -4,7 +4,8 @@ | |||
"description": "", | |||
"main": "server.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should now be
"main": "backend/src/server.js",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! i think since this is in the backend dir though it should be src/server.js
. unless you want to rollup the dependencies into one package.json
at the root of this repo.
updated here: d6c8a39
hey @DashBarkHuss i'm doing some house keeping and will close this as I haven't given it much thought since its inception! ✌️ |
If the API is going to run on heroku docker, here are a few proposed to changes to get that going. Namely:
backend
into.env
file and hydrate them via dotenvsrc
dirlocalhost
for non development environments.server
but not inpackage.json
package-lock.json
forfrontend