Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker for backend use #1

Closed
wants to merge 8 commits into from
Closed

Conversation

higgins
Copy link

@higgins higgins commented Apr 10, 2022

If the API is going to run on heroku docker, here are a few proposed to changes to get that going. Namely:

  1. Extract a few variables in backend into .env file and hydrate them via dotenv
  2. Move all the server's runtime dependencies under src dir
  3. Add a "DREAM_ENV" environment variable which represents which environment the app will run in (ie development/production)
  4. Don't allow localhost for non development environments.
  5. Add a few npm dependencies that were referenced in server but not in package.json
  6. Update the package-lock.json for frontend

backend/src/server.js Outdated Show resolved Hide resolved
@@ -4,7 +4,8 @@
"description": "",
"main": "server.js",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be
"main": "backend/src/server.js",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! i think since this is in the backend dir though it should be src/server.js. unless you want to rollup the dependencies into one package.json at the root of this repo.

updated here: d6c8a39

@higgins
Copy link
Author

higgins commented Oct 17, 2023

hey @DashBarkHuss i'm doing some house keeping and will close this as I haven't given it much thought since its inception! ✌️

@higgins higgins closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants