Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low level interfering crackling/popping of the speakers while playing no sound #224

Closed
mkopec opened this issue Oct 11, 2022 · 13 comments
Closed
Labels
bug Something isn't working novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen)

Comments

@mkopec
Copy link
Member

mkopec commented Oct 11, 2022

Issue migrated from GitLab

Dasharo version

v0.5.0

Hardware details

Clevo NV40MZ-i7

Affected component(s) or functionality

Speakers

Brief summary

While not playing any sound, the speakers are lightly cracking, like an interfering sound.

How reproducible

100% reproducible.

How to reproduce

Steps to reproduce the behavior:

  1. Turn on the laptop.
  2. Boot into Windows or Ubuntu.
  3. Notice the speakers that are very lightly cracking or popping.

Expected behavior

No speakers crackling.

Actual behavior

Speakers crackling.

Screenshots

Additional context

This issue does not happen on original Insyde firmware. Perhaps the speakers are muted if no sound is detected?

Solutions you've tried

None.

/cc @macpijan

@mkopec mkopec added the novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) label Oct 11, 2022
@mkopec mkopec closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
@mkopec mkopec reopened this Oct 11, 2022
@mkopec
Copy link
Member Author

mkopec commented Oct 11, 2022

Note: This is likely to be coil whine that appears while the device is idle (especially noticeable in deeper C-states)

@Pokisiekk Pokisiekk added the bug Something isn't working label Nov 21, 2022
@macpijan
Copy link
Contributor

Report from NovaCustom is that the Insyde firmware has the same behavior.

@mkopec
Copy link
Member Author

mkopec commented Feb 24, 2023

Happens every time the device reaches C-state C8 or lower, including when it's idling with the screen off (or in self-refresh if applicable) and in S0ix sleep.

@Brice123456789
Copy link

NovaCustom NV40 computer, Intel Core i5. Firmware 1.4. Debian 12 GNOME.

This behavior happens with power-profiles-daemon in "Performance mode".
The use of TLP instead of power-profiles-daemon triggers this too.

@wessel-novacustom
Copy link

@mkopec is there any possible firmware solution for this, you think?

@mkopec
Copy link
Member Author

mkopec commented Oct 25, 2023

@wessel-novacustom coil whine can be mitigated using Acoustic Noise Optimization. We did some testing a while ago to see if it could help, but the various settings for this feature need some testing for stability (since they affect SoC power delivery) so as of now it's not enabled.

@wessel-novacustom
Copy link

That's great. How exactly can we enable this? Can that be done by firmware?

@mkopec
Copy link
Member Author

mkopec commented Oct 25, 2023

Can that be done by firmware?

@wessel-novacustom Yes, it's a set of options in Intel FSP

@wessel-novacustom
Copy link

Ok, perfect. It would be great if it could be implemented for a next firmware update or even the October update.

@wessel-novacustom
Copy link

@mkopec
Copy link
Member Author

mkopec commented Dec 1, 2023

Acoustic Noise Mitigation was implemented for ADL models in commit Dasharo/coreboot@cad41c1 and TGL in commits Dasharo/coreboot@30d9759 and Dasharo/coreboot@ca9a0b3

This not only reduced coil whine, but also fixed some freezes and glitches in the board logic. Before these changes I saw the ACIN signal on EC turning on randomly despite there being no charger plugged in

@mkopec mkopec closed this as completed Dec 1, 2023
@mkopec mkopec reopened this Dec 1, 2023
@wessel-novacustom
Copy link

The noise has been reduced massively with the latest test binaries indeed, so I believe this should be marked as solved @mkopec.

@mkopec mkopec closed this as completed Dec 12, 2023
@mkopec
Copy link
Member Author

mkopec commented Dec 13, 2023

RFI mitigation on TGL might also help with Bluetooth and WiFi reception :) Not sure about ADL though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen)
Projects
None yet
Development

No branches or pull requests

5 participants