Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ability to change active PCR banks with TPM PPI in FW #521

Open
johanes2115 opened this issue Oct 12, 2023 · 4 comments
Open

No ability to change active PCR banks with TPM PPI in FW #521

johanes2115 opened this issue Oct 12, 2023 · 4 comments
Assignees
Labels
bug Something isn't working MSI PRO Z690-A boards MSI PRO Z790-P boards novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) protectli_vault_cml VP 4xxx

Comments

@johanes2115
Copy link

Device

novacustom nv41 ADL

Dasharo version

v1.7.0

Affected component(s) or functionality

TPM

Brief summary

In TCG configuration, after changing active PCR bank and restarting the device, TPM state change request prompt does not appear and the settings go back to values before the change.

How reproducible

100%

How to reproduce

  1. Power on the device
  2. Enter the BIOS
  3. Go into Device Manager -> TCG2 Configuration
  4. Change active PCR banks
  5. Save settings and restart the device

Expected behavior

TPM state change request prompt should appear and and active PCR banks should change.

Actual behavior

TPM state change request prompt does not appear and and active PCR banks remain the same.

Screenshots

No response

Additional context

No response

Solutions you've tried

No response

@johanes2115 johanes2115 added bug Something isn't working novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen) labels Oct 12, 2023
@johanes2115 johanes2115 self-assigned this Oct 12, 2023
@macpijan
Copy link
Contributor

This also has not worked with the previous releases, such as v1.6.0 on NV4x ADL. This should probably be moved to the next releases, not the hotfix ones.

@filipleple
Copy link
Member

still occurs on MSI ZX90 for both respective v1.1.3 and v0.9.1 releases

@Psotas Psotas added the novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) label Dec 29, 2023
@miczyg1
Copy link
Contributor

miczyg1 commented Jan 2, 2024

Indeed, it is not working on Z790-P v0.9.1, but worked on v0.9.0. We might have some regression either in edk2 payload or coreboot side after rebase...

@filipleple
Copy link
Member

same for VP4670, the protectli_vault_cml_v1.1.0_vp46xx (coreboot 4.21 rebase) binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MSI PRO Z690-A boards MSI PRO Z790-P boards novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) protectli_vault_cml VP 4xxx
Projects
Status: Backlog
Development

No branches or pull requests

6 participants