Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No HDMI output in firmware #533

Open
johanes2115 opened this issue Oct 18, 2023 · 8 comments
Open

No HDMI output in firmware #533

johanes2115 opened this issue Oct 18, 2023 · 8 comments
Assignees
Labels
bug Something isn't working novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen)

Comments

@johanes2115
Copy link

Device

Novacustom TGL

Dasharo version

v1.7.0

Affected component(s) or functionality

HDMI output

Brief summary

There is no HDMI output in firmware, which makes remote automatic validation not possible.

How reproducible

100%

How to reproduce

  1. Connect external HDMI output
  2. Power on the device

Expected behavior

HDMI output in firmware.

Actual behavior

No HDMI output in firmware.

Screenshots

No response

Additional context

No response

Solutions you've tried

No response

@johanes2115 johanes2115 added bug Something isn't working novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) labels Oct 18, 2023
@johanes2115 johanes2115 self-assigned this Oct 18, 2023
@mkopec
Copy link
Member

mkopec commented Oct 19, 2023

AlderLake FSP has a LidStatus option that tells the GOP driver which screen to use. Looks like TigerLake FSP doesn't have it. Not sure what can be done here. Maybe have 2 VBTs in CBFS and switch between them depending on lid state? @miczyg1

@miczyg1
Copy link
Contributor

miczyg1 commented Oct 19, 2023

Unfixable. TGL FSP creates the GOPPolicy with GetPlatformLidStatus returning EFI_UNSUPPORTED. So unless you hack your own FSP and expose such option, this is not doable.

@pietrushnic
Copy link

@miczyg1 AFAIK, we should be able to do that. Another reason is to choose Dasharo.

@miczyg1
Copy link
Contributor

miczyg1 commented Oct 19, 2023

@miczyg1 AFAIK, we should be able to do that. Another reason is to choose Dasharo.

Yes, we can.

@macpijan
Copy link
Contributor

There is no HDMI output in firmware, which makes remote automatic validation not possible.

Just to make it clear here, we can still run automated tests as we do not really rely on the display in actual tests.
It is more convenient to use though, if we can remotely use the display, of course.

@mkopec
Copy link
Member

mkopec commented Nov 2, 2023

If we really need this, we can just unplug the eDP cable, FSP will see it's missing and output to HDMI :^)

@mkopec
Copy link
Member

mkopec commented Nov 23, 2023

@miczyg1 could we not just include the Intel GOP driver in UEFIPayload and run it with policy specified by UEFI instead of coreboot?

@mkopec
Copy link
Member

mkopec commented Jan 8, 2024

If we really need this, we can just unplug the eDP cable, FSP will see it's missing and output to HDMI

Yeah, I needed KVM to debug issues with testing quicker, and just unplugged the eDP cable and I get FW on HDMI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen)
Projects
None yet
Development

No branches or pull requests

5 participants