Incorrect vendor name in SMBIOS NS70/50 v1.1.0

[sulewskiprzemyslaw]

Dasharo version

v1.1.0

Dasharo variant

Dasharo workstation

Affected component(s) or functionality

Vendor name display

Brief summary

The vendor name is different than expected.

How reproducible

The issue occurs every time vendor name is checked.

How to reproduce

Steps to reproduce the behavior:

1. Open a terminal window and run sudo dmidecode -t bios
2. n the BIOS Information section, check the Version field against the guidelines and dmidecode.log

Expected behavior

The Vendor field, for firmware with an initial release date after 13 January 2021, is set as follows:

3mdeb

Actual behavior

The Vendor field is set as follows:

3mdeb Embedded Systems Consulting

Screenshots

Additional context

Solutions you've tried

[macpijan]

@mkopec @miczyg1 Do we follow this rule for new releases? Should it be really 13 January 2021, not 2022? It comes from here: https://docs.dasharo.com/dev-proc/smbios-rules/

Changing vendor changes fwupd GUIDs?

[pietrushnic]

@macpijan it should be 2022, I don't know how I missed that in review.

[mkopec]

Changing vendor changes fwupd GUIDs?

Yes, changing the vendor field will change the GUIDs.

[macpijan]

@pietrushnic Another thing to consider would be:
"The Vendor field, for firmware with initial release date" - so, of the initial release for the given platform was prior that date, we would stick to the old vendor name, even for the newer releases.

I think we should update the vendor name in all releases past given date. WDYT?

[pietrushnic]

@macpijan yes, that make sense.

[macpijan]

@mkopec Pleas link release notes of version which fixes that once published.

[macpijan]

Can you also fix SMBIOS documentation according to the discussion above (if not done already)?

[mkopec]

@macpijan fix: Dasharo/docs#204 - fixed the year and removed the initial qualifier

[mkopec]

Closing as fixed in v1.2.0