Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core 3 / .NET Standard 2.1 #46

Closed
Numpsy opened this issue Aug 29, 2019 · 10 comments
Closed

.NET Core 3 / .NET Standard 2.1 #46

Numpsy opened this issue Aug 29, 2019 · 10 comments

Comments

@Numpsy
Copy link

Numpsy commented Aug 29, 2019

Hi,

I see that the most recent version of the library has been adapted to use the built in IAsyncEnumerable in .NET Core 3, but can I ask what the situation is with .NET Standard 2.1? (from a quick test, looks like it uses its own definition there rather than the built in version?).

Thanks.

@kind-serge
Copy link
Member

@Numpsy, with the yesterday's official release of NET Core 3 and NET Standard 2.1 this library has been updated as well. Thanks for waiting!

@silkfire
Copy link

silkfire commented Oct 9, 2019

@kind-serge Does an implementation of ParallellForEachAsync exist in .NET Core 3.0 or should we keep using your library?

@kind-serge
Copy link
Member

@silkfire to my best knowledge ParallellForEachAsync does not exist in the latest .NET BCL and I have no info on whether it will be added or not. Keep using this library for now.

@Numpsy
Copy link
Author

Numpsy commented Oct 16, 2019

On a sort of related note - Microsoft have released a Microsoft.Bcl.AsyncInterfaces package that has definitions of IAsyncEnumerable and such for versions of .NET prior to Standard 2.1.

Any thoughts on using ParallellForEachAsync with those definitions?

@kind-serge
Copy link
Member

@Numpsy , thanks for the info! I was not aware of that package.
Apparently it works for .NET Standard 2.0 only and no lower versions.
It is an easy change, however will have to bump the major version of this library to accommodate these changes.

@kind-serge
Copy link
Member

@Numpsy , the new version has been released: https://www.nuget.org/packages/AsyncEnumerator/4.0.0

@Numpsy
Copy link
Author

Numpsy commented Oct 20, 2019

Thanks, I'll give it a go.

@Numpsy
Copy link
Author

Numpsy commented Oct 21, 2019

I tried it in a .Net Standard 2.0 library called from a .Net 4.7.2 application and hit some errors about missing methods, i'm guessing because the library is using the interface definitions from the Microsoft package, but the build for the app is pulling in the .Net 4.5 build of AsyncEnumerator that doesn't contain matching methods?
(The Microsoft.Bcl.AsyncInterfaces package does actually appear to contain a build for .Net 4.6.1 on top of the .Net standard version, so I think the app sees those ok.)

@kind-serge
Copy link
Member

Seems like a .NET Fx 4.6.1 (and higher) project uses the .NET Fx 4.5 version of the library instead of .NET Std 2.0. I updated the NuGet Package with the .NET Fx 4.6.1 version of this library to be compatible with .NET Std 2.0 projects: https://www.nuget.org/packages/AsyncEnumerator/4.0.1

@Numpsy
Copy link
Author

Numpsy commented Oct 22, 2019

Thanks, that seems ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants