Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I use jbr_jcef as the runtime, can I avoid re-downloading the runtime during startup? #9

Open
bulletjet786 opened this issue Mar 10, 2024 · 7 comments

Comments

@bulletjet786
Copy link
Contributor

If I use jbr_jcef as the runtime, can I avoid re-downloading the runtime during startup? And if so, what steps should I take to ensure this?

@DatL4g
Copy link
Owner

DatL4g commented Mar 10, 2024

Never tested it but may work if all required binaries are included. It's a bit tricky as the files are platform dependend.

However KCEF does not support this in any form currently.

You could try initializing CEF yourself https://github.com/DatL4g/KCEF/blob/master/kcef/src/main/kotlin/dev/datlag/kcef/step/init/CefInitializer.kt and report back, maybe we can implement such a feature then.

The CEF library can be loaded using implementation("dev.datlag:jcef:2024.01.07.1")

@bulletjet786
Copy link
Contributor Author

Thank you.I will check it.

@bulletjet786
Copy link
Contributor Author

Excuse me, is there a plan for KCEF to support directly running the JBR_JCEF Runtime as mentioned above?

@bulletjet786
Copy link
Contributor Author

I would like to adjust the constructor of KCEFClient and KCEFBrowser to be public, thereby enabling the initialization of kcef objects using existing jcef examples. If you don't have the time to do this, I can take care of it. Would that be alright?

@DatL4g
Copy link
Owner

DatL4g commented Apr 18, 2024

Sure go ahead, I think making the KCEFClient constructor public is enough as the KCEFBrowser can be created by calling client.createBrowser(CefBrowser)

@bulletjet786
Copy link
Contributor Author

#11 I have already submitted code; please check it.

@DatL4g
Copy link
Owner

DatL4g commented Apr 20, 2024

New release available:

// KCEF
implementation("dev.datlag:kcef:2024.04.20")

// jcef
implementation("dev.datlag:jcef:2024.04.20")

with updated jcef core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants