Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data standards #149

Merged
merged 11 commits into from
Aug 3, 2018
Merged

Data standards #149

merged 11 commits into from
Aug 3, 2018

Conversation

terryf82
Copy link
Collaborator

set default city lat/lng in new config from geocoded response

@j-t-t
Copy link
Collaborator

j-t-t commented Aug 1, 2018

Let's get Shreya's initialize_city test changes into master before we merge this so we can decide whether you should flesh out the test you wrote or just update her test

@j-t-t
Copy link
Collaborator

j-t-t commented Aug 1, 2018

The test_brisbane_config file is getting written to src/. Can you create a temp directory and write there instead?

@terryf82
Copy link
Collaborator Author

terryf82 commented Aug 1, 2018

@j-t-t thanks, path updated and CI tests running now.

@j-t-t
Copy link
Collaborator

j-t-t commented Aug 2, 2018

Sorry, I should have been more specific. Best to use a tmpdir created for this test. Test functions can take an argument called tmpdir and you can use that. https://docs.pytest.org/en/latest/tmpdir.html

@terryf82
Copy link
Collaborator Author

terryf82 commented Aug 2, 2018

@j-t-t thanks, updated with proper use of tmpdir fixture.

@j-t-t j-t-t merged commit 45da9f3 into master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants