Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAWB-3349: Remove compute scopes from FC #32

Closed
irosenbe opened this issue Apr 13, 2018 · 0 comments
Closed

GAWB-3349: Remove compute scopes from FC #32

irosenbe opened this issue Apr 13, 2018 · 0 comments
Assignees

Comments

@irosenbe
Copy link
Collaborator

Description:
As a user of FireCloud and Saturn, I should be able to use either platform without needing to be granted advanced scopes (specifically for this ticket, Google Compute Engine).

Verily analysts supporting BVDP and AMP-PD driver projects cannot make use of this system unless this is done.

Implementation Notes:
I have heard multiple times now that "we have never needed the compute scope" for end users. In theory, then, this ticket is as simple as removing our oauth request for this scope. However, please make sure to test thoroughly to ensure no regressions.

This scope needs to be removed from two places:

  1. The UI's oauth request at https://github.com/broadinstitute/firecloud-ui/blob/develop/src/cljs/main/broadfcui/auth.cljs#L29
  2. The API's oauth request in swagger-ui, found in multiple locations in https://github.com/broadinstitute/firecloud-orchestration/blob/develop/src/main/resources/swagger/api-docs.yaml

Link to GAWB ticket: https://broadinstitute.atlassian.net/browse/GAWB-3349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants