Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAWB-3261: Calling POST /register/profile with a plus in contactEmail returns 400 #5

Closed
irosenbe opened this issue Apr 12, 2018 · 0 comments
Labels
AoU Support AoU Support

Comments

@irosenbe
Copy link
Collaborator

Acceptance Criteria:
An email with a plus in it in the contact. Email field can be registered successfully.

Description:
Reported by AoU folks. They tried to register jmandel+aou-rw-stable@verily.com as a contact email and it fails.

Plus is a valid character in email addresses. We should be OK with it.

Implementation notes:
This could be a problem with orch's email validation:
https://github.com/broadinstitute/firecloud-orchestration/blob/develop/src/main/scala/org/broadinstitute/dsde/firecloud/model/Profile.scala#L112

NB: this bug affects users who are updating their profile as well as newly-registering users. Therefore as a developer, you can test/reproduce this simply by updating your profile.

Testing note: API level testing, no need for selenium

Link to GAWB ticket: https://broadinstitute.atlassian.net/browse/GAWB-3261

@gemmalam gemmalam assigned ghost Apr 12, 2018
@gemmalam gemmalam added the AoU Support AoU Support label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AoU Support AoU Support
Projects
None yet
Development

No branches or pull requests

3 participants