Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having attributes in mappings that don't exist doesn't raise any error or warning. #471

Open
KhaledTo opened this issue May 11, 2019 · 0 comments

Comments

@KhaledTo
Copy link
Contributor

KhaledTo commented May 11, 2019

When specifying a model, if I add some attributes that don't exist in my dataset I get no warnings or errors. To reproduce, you can use the sample model.json file in examples/hello_world folder:

            "mappings": {
                        "item.line_item": "line_item",
                        "item.subcategory": "subcategory",
                        "item.subcategory_label": "subcategory_label",
                        "item.category": "category",
                        "item.cpu_item": "cpu_item",
                        "item.category_label": "category_label",
                        "item.year_item": "year_item",
                        "item.doesntexist1": "itemdoesntexist1",
                        "item.doesntexist2": "itemdoesntexist2"
                         },
@KhaledTo KhaledTo changed the title Having attributes in mappings that don't exist doesn't raise any error or warnings. Having attributes in mappings that don't exist doesn't raise any error or warning. May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant