Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling non-Points #34

Open
hylkevds opened this issue Nov 9, 2020 · 3 comments
Open

Styling non-Points #34

hylkevds opened this issue Nov 9, 2020 · 3 comments

Comments

@hylkevds
Copy link
Collaborator

hylkevds commented Nov 9, 2020

I noticed it was not possible to style non-point Locations / Features when using Leaflet. I pushed a simple update that adds a config option to fix that. I've not checked if it is an issue in OpenLayers as well though.

@hylkevds
Copy link
Collaborator Author

@TobiasPressler can you have a look at the commit, does it match your design ideas? :)

@hylkevds
Copy link
Collaborator Author

I just noticed that the count-squares are added to the same layer as the Locations/Features, so the styling function is currently also called for them.

I also noticed that the styling function is re-called for every "update" tick of the L.realtime layer (currently every 300 milliseconds), which is also not ideal.

@TobiasPressler
Copy link
Collaborator

So maybe add a wrapper function that caches the styling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants