Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: Refactor the Spider class to reduce the max args. Use a dataclass #9

Closed
indrajithi opened this issue Jun 14, 2024 · 1 comment
Closed

Housekeeping: Refactor the Spider class to reduce the max args. Use a dataclass #9

indrajithi opened this issue Jun 14, 2024 · 1 comment
Assignees
@indrajithi
Labels
house keeping
Milestone
First major relea...

Comments

@indrajithi
Copy link
Collaborator

No description provided.

@indrajithi indrajithi self-assigned this Jun 14, 2024
@indrajithi indrajithi changed the title Feature: Refactor the Spider class to reduce the max args. Use a config class Housekeeping: Refactor the Spider class to reduce the max args. Use a config class Jun 15, 2024
@indrajithi indrajithi changed the title Housekeeping: Refactor the Spider class to reduce the max args. Use a config class Housekeeping: Refactor the Spider class to reduce the max args. Use a dataclass Jun 16, 2024
@Mews
Copy link
Collaborator

Mews commented Jun 16, 2024 •
edited
Loading

Wasn't this addressed in #15 ? Maybe you should close the issue.
Unless there are more changes to make, if so I can try to do them

@indrajithi indrajithi mentioned this issue Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indrajithi indrajithi

Labels
house keeping
Projects
None yet
Milestone
First major release v.1.0.0
Development

No branches or pull requests
2 participants
@indrajithi @Mews