Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.59 tag is available on the official Go proxy but not on this repository #218

Closed
mx-psi opened this issue Jan 5, 2023 · 3 comments
Closed

Comments

@mx-psi
Copy link
Member

mx-psi commented Jan 5, 2023

Similarly to go-chi/chi/issues/713 or ionos-cloud/sdk-go/issues/27, the v5.0.59 tag is available in the official Go proxy but not on this repository, which causes trouble to dependent modules.

As stated in the IONOS issue:

It is impossible to remove the module from the Go proxy, so the correct approach is to

  1. re-publish the tag on the same commit and
  2. release a new [5.x] version that includes a retract directive for the bad version.

Otherwise, this will break people's builds, and automatic dependency management tools may still see the bad version and suggest upgrading to it.

@mx-psi
Copy link
Member Author

mx-psi commented Jan 5, 2023

@JLineaweaver could you take a look at this? IMO the best solution is to add a retract for v5.0.59 and skip all versions before it by releasing a v5.0.60 version

@JLineaweaver
Copy link
Contributor

@mx-psi Created both https://github.com/DataDog/agent-payload/releases/tag/v5.0.59 and https://github.com/DataDog/agent-payload/releases/tag/v5.0.60. Retraction added to go.mod and a full redeploy of master

@mx-psi
Copy link
Member Author

mx-psi commented Jan 10, 2023

Thanks! I think this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants