Allow to specify trace env #435
Conversation
|
Hi @krasnoukhov, thanks for adding this! Actually I just merged #433 and it conflicts with your PR unfortunately, could you rebase yours? (and maybe change the template condition to |
|
@olivielpeau Done |
There was a problem hiding this comment.
Thanks @krasnoukhov, one last thing to change and it should be good to merge
templates/default/datadog.conf.erb
Outdated
| @@ -183,6 +183,11 @@ end | |||
| apm_enabled: <%= node['datadog']['enable_trace_agent'] %> | |||
| <% end -%> | |||
|
|
|||
| [trace.config] | |||
| <% unless node['datadog']['trace_env'].nil? -%> | |||
| env = <%= node['datadog']['trace_env'] %> | |||
There was a problem hiding this comment.
Could you use env: instead of env = here? I know the 2 syntaxes should be similar in the ini format but still I'd rather be consistent with the other options
There was a problem hiding this comment.
Oh yeah totally missed that. I copied the line from documentation initially, so that could be changed as well
|
Thanks! Merging |
Our APM just recently started reporting to "env:none". Adding
tagsto adatadog.confdoes not help for whatever reason. I noticed that configuring trace like this is missing from chef, so here we go.https://app.datadoghq.com/apm/docs/tutorials/environments