New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moises.botarro/adding data scrubber fields process agent #540
Merged
olivielpeau
merged 8 commits into
master
from
moises.botarro/adding-data-scrubber-fields-process-agent
Apr 17, 2018
Merged
Moises.botarro/adding data scrubber fields process agent #540
olivielpeau
merged 8 commits into
master
from
moises.botarro/adding-data-scrubber-fields-process-agent
Apr 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attributes/default.rb
Outdated
@@ -367,6 +367,11 @@ | |||
# Example: ['my-secret-app', 'dbpass'] | |||
default['datadog']['process_agent']['blacklist'] = [] | |||
|
|||
# Controls the behavior of the cmdline dataScrubber | |||
# Example for custom sensitive words: ['consul_token', 'token', 'dd_api_key'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put this comment above the custom_sensitive_words
and instead add a comment here on what scrub_args
enables?
shang-wang
approved these changes
Apr 16, 2018
conorbranagan
approved these changes
Apr 16, 2018
olivielpeau
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
olivielpeau
deleted the
moises.botarro/adding-data-scrubber-fields-process-agent
branch
April 17, 2018 15:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new fields for process-agent to enable/disable the cmdline data scrubber and to expand list of sensitive words to match.
@DataDog/burrito