Let the Windows installer set the correct rights on config files and directories.

[remeh]

The .MSI to setup the Agent on Windows will soon run the Agent in a custom user with less privileges (than Administrator).

This commit removes the permissions change on datadog.yaml on Windows to let the installer set it itself.

I've tested that the Agent still runs while installing 6.8.0 and 6.10.0.

Note that this PR doesn't change the behavior for the Agent 5.

[olivielpeau]

need to check: whether earlier versions of the cookbook work with agents v6 >= 6.11 (on Windows)

[remeh]

I've tested it with versions <6.11 (such as 6.8.0) and it worked well 👍
I've also tested upgrading from 6.8 to the 6.10 with the user.

[olivielpeau]

2 comments:

• What about the similar logic in our datadog_monitor provider?

  chef-datadog/providers/monitor.rb

  Lines 13 to 17 in 0cc4f6a

  	if node['platform_family'] == 'windows'
  	owner 'Administrators'
  	rights :full_control, 'Administrators'
  	inherits false
  	else

• I think there was a small misunderstanding on my earlier comment: I meant to ask if version 2.17.0 of the cookbook is able to successfully install a version of the Windows Agent running under dd-agent-user. If not, it means that users trying to install such a Windows Agent version with older versions of the cookbook will run into issues, so we should make sure it's documented in a very obvious way (here + in the Agent changelog + any other docs we may provide; we can discuss this in chat/offline if needed)

[remeh]

1. Nice catch 👍
2. Indeed, chef-datadog runs just fine but the Agent (with ddagentuser) is not able to run due to the Administrators permissions set on the directories/files by the cookbook. You're right we'll need to document this carefully because it's a very specific situation (specific OS + specific min version of the Agent v6 + specific version of chef-datadog).

[remeh]

Please note that the CHANGELOG for release 2.18.0 has been updated accordingly: #589

[olivielpeau]

Left a few additional comments