Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make sure apt/yum cookbooks are loaded when dd-handler is run #6

Closed
alq666 opened this issue Jul 25, 2012 · 5 comments
Closed
Assignees

Comments

@alq666
Copy link
Member

alq666 commented Jul 25, 2012

Can move this to default and include it in both dd-agent and dd-handler recipes.

@ghost ghost assigned alq666 Jul 25, 2012
@miketheman
Copy link
Contributor

Can you elaborate as to why apt/yum are needed for dd-handler?

@alq666
Copy link
Member Author

alq666 commented Aug 9, 2012

ruby-dev needed to compile json iirc.

On Aug 9, 2012, at 8:26 AM, Mike Fiedler notifications@github.com wrote:

Can you elaborate as to why apt/yum are needed for dd-handler?


Reply to this email directly or view it on GitHub.

@miketheman
Copy link
Contributor

Ok, it seems like it's a requirement for yajl-ruby before it's a requirement for json, but also a requirement there.

I wonder id any system installing a modern version of chef won't already have this?

@alq666
Copy link
Member Author

alq666 commented Sep 15, 2012

I interpret https://github.com/DataDog/chef-datadog/blob/master/metadata.rb#L9 as a solution to this bug.

@alq666 alq666 closed this as completed Sep 15, 2012
@miketheman
Copy link
Contributor

I support closure of this bug, but think it might be for the wrong reason. Adding a dependency to the metadata doesn't ensure that any actions/resources are activated unless an include_recipe statement is run, such as is used here.

Also, since the handlers are being installed at compile time, I suspect we should probably remove these lines, as json, yajl-json are requirements of chef itself, and would have to have been resolved prior to running chef itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants