Default skip_ssl_validation into false #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingkaihe
force-pushed
the
default-skip-ssl-validation-to-false
branch
from
e401e40
to
26c4972
Compare
albertvaka
reviewed
Feb 26, 2020
attributes/default.rb
Outdated
| @@ -247,7 +247,7 @@ | |||
| default['datadog']['web_proxy']['port'] = nil | |||
| default['datadog']['web_proxy']['user'] = nil | |||
| default['datadog']['web_proxy']['password'] = nil | |||
| default['datadog']['web_proxy']['skip_ssl_validation'] = nil # accepted values 'yes' or 'no' | |||
| default['datadog']['web_proxy']['skip_ssl_validation'] = false | |||
There was a problem hiding this comment.
Can we keep it nil here and just change the comment? This way it won't appear in the configuration if not set, thus using the default.
There was a problem hiding this comment.
Thanks for the feedback. I've addressed the comment.
Tweak comments on skip_ssl_validation that suggests true/false is supported value to be populated into datadog config, which is compatible across agent v5, v6, and v7
jingkaihe
force-pushed
the
default-skip-ssl-validation-to-false
branch
from
26c4972
to
c64dd40
Compare
|
Thanks a lot for finding this! Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #692
Modified comments on skip_ssl_validation that suggests true/false is supported value to be populated into datadog config, which is compatible across agent v5, v6, and v7