[datadog_monitor] Fix crash for jmx integrations with init_config attributes set #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a crash when the
init_config
attribute for a jmx integration (such asignite
,jboss_wildfly
) is set.Previously, the
init_config
attribute would be merged in-place (through themerge!
method) with another hash:{ 'is_jmx': true, 'collect_default_metrics': true }
. This would cause a crash ifinit_config
is defined in attributes, because chef attributes cannot be modified that way:This PR fixes this by not merging the attributes in-place. It also adds a kitchen test which exhibits the previous faulty behavior.