Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent mode to datadog-ci sourcemaps upload #1056

Open
jakub-g opened this issue Aug 31, 2023 · 1 comment
Open

Add silent mode to datadog-ci sourcemaps upload #1056

jakub-g opened this issue Aug 31, 2023 · 1 comment
Labels
enhancement New feature or request source-code-integration Related to [git-metadata]

Comments

@jakub-g
Copy link
Member

jakub-g commented Aug 31, 2023

Feature request description

Currently, datadog-ci sourcemaps upload logs a line in output for every single file it uploads. If there's 1000 files uploaded, it will log 1000 lines, which is too much.

Solution

It would be nice to have a "silent" mode (name TBD) which only logs warnings/errors and the summary

For example, with a --verbose flag which defaults to true, and can be disabled via --no-verbose (negation is handled by clipanion):

  • --verbose = log everything
  • --no-verbose = only log warnings, errors, summary

Alternatively to have better control: have a param like --log-level which can more fine-grained (log, warn, error, default: log) and perhaps a separate --log-summary boolean, default: true.

Additional context

No response

Command

sourcemaps

@jakub-g jakub-g added the enhancement New feature or request label Aug 31, 2023
@github-actions github-actions bot added the source-code-integration Related to [git-metadata] label Aug 31, 2023
@jakub-g
Copy link
Member Author

jakub-g commented Aug 31, 2023

The problem I'm trying to solve:

In GitLab, if logs are too long, they get truncated in GitLab web interface; then you have a header like Showing last 499.79 KiB of log - [Complete Raw] with a link to raw log which is a TXT file, which is difficult to read, because it doesn't strip ascii escape codes, so it's a lot of "black text with escape codes, on white background" lines.

Apart from not supporting colors, and not stripping escape codes, raw logs obviously do not support "collapsable sections". This makes comparing two logs from two CI jobs difficult (super long outputs, no colors, and you can't compare timings of "sections" which is a built-in feature of GitLab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source-code-integration Related to [git-metadata]
Projects
None yet
Development

No branches or pull requests

1 participant