Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running sourcemaps upload fails with old GCC #1061

Open
petems opened this issue Sep 11, 2023 · 0 comments
Open

Running sourcemaps upload fails with old GCC #1061

petems opened this issue Sep 11, 2023 · 0 comments
Labels
bug Something isn't working source-code-integration Related to [git-metadata]

Comments

@petems
Copy link

petems commented Sep 11, 2023

Bug description

On RHEL / CentOS (GCC 4)

CI/.gradle/nodejs/node-v12.18.3-linux-x64/bin/npx @datadog/datadog-ci@2.19.1 sourcemaps upload ./build --service=example --release-version=6.5.1-test-b53 --minified-path-prefix=/static/js

Successfully started process 'command 'CI/.gradle/nodejs/node-v12.18.3-linux-x64/bin/npx''

In file included from ../deps/cpu_features/src/impl_x86__base_implementation.inl:89:0,

                 from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:

../deps/cpu_features/src/copy.inl: In function ‘copy’:

../deps/cpu_features/src/copy.inl:18:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < count; ++i) dst[i] = src[i];

   ^

../deps/cpu_features/src/copy.inl:18:3: note: use option -std=c99 or -std=gnu99 to compile your code

In file included from ../deps/cpu_features/src/impl_x86__base_implementation.inl:91:0,

                 from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:

../deps/cpu_features/src/equals.inl: In function ‘equals’:

../deps/cpu_features/src/equals.inl:19:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < count; ++i)

   ^

In file included from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:0:

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseLeaf2’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1730:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < sizeof(data); ++i) {

   ^

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseCacheInfo’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1746:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (int index = 0; info.size < CPU_FEATURES_MAX_CACHE_LEVEL; ++index) {

   ^

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseCacheInfoLegacyAMD’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1873:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (int i = 0; i < LEGACY_AMD_MAX_CACHE_LEVEL; ++i) {

   ^

../deps/cpu_features/src/impl_x86_linux_or_android.c: In function ‘DetectFeaturesFromOs’:

../deps/cpu_features/src/impl_x86_linux_or_android.c:37:5: error: ‘for’ loop initial declarations are only allowed in C99 mode

     for (bool stop = false; !stop;) {

     ^

Looks like a similar issue happened with the PHP trace library, and looks like adding the -99 to the build options was put in as a fix: DataDog/dd-trace-php#396

Describe what you expected

No response

Steps to reproduce the issue

No response

Additional context

No response

Command

sourcemaps

@petems petems added the bug Something isn't working label Sep 11, 2023
@github-actions github-actions bot added the source-code-integration Related to [git-metadata] label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working source-code-integration Related to [git-metadata]
Projects
None yet
Development

No branches or pull requests

1 participant