Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security vulnerability in axios SNYK-JS-AXIOS-6032459 #1096

Closed
mishabruml opened this issue Oct 26, 2023 · 7 comments · Fixed by #1108
Closed

security vulnerability in axios SNYK-JS-AXIOS-6032459 #1096

mishabruml opened this issue Oct 26, 2023 · 7 comments · Fixed by #1108
Labels
bug Something isn't working

Comments

@mishabruml
Copy link

Bug description

https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459

Looks like it's not fixed at the moment in axios but I suppose it will be soon.

As an aside, the current version 0.21.4 used in this package is around 2 years old, is there any reason it couldn't be updated to the latest version 1.5.1? It would mean a major version change, there doesn't seem to be official breaking changes guide, there are some community ones though - see axios/axios#4996

Describe what you expected

No response

Steps to reproduce the issue

No response

Additional context

No response

Command

None

@mishabruml mishabruml added the bug Something isn't working label Oct 26, 2023
@mishabruml
Copy link
Author

looks like axios are on it axios/axios#6022

@Drarig29
Copy link
Contributor

Drarig29 commented Nov 6, 2023

Hi @mishabruml! We've had issues bumping axios in the past, because its move to ESM was not working properly with our standalone binary. Also, the latest fix that was published by axios seems to be a breaking change: axios/axios#6028 (comment)

From the maintainer of axios:

I felt that this was not an actual CVE in all honesty as the implementor has control over this and if they decide to set the flag to true they should have understood what that meant.

This is only a vulnerability when withCredentials is set to true, which isn't our case.

@tobiasweibel
Copy link

I can see the ESM issues and don't really like to fix such issues in projects of my company.
BUT: As my company runs security scanners it will assert the axios issue and we basically have to address it somehow.

@psinglet
Copy link

psinglet commented Nov 8, 2023

This is now causing failures on all scans that use datadog plugins, when can we expect a fix for this?

@Drarig29
Copy link
Contributor

Drarig29 commented Nov 9, 2023

Hi, just a heads up: we are working on it, a PR is being reviewed.

@mishabruml
Copy link
Author

@Drarig29 thanks for this, could you re-open the issue until this is released? 😄

@Drarig29
Copy link
Contributor

Drarig29 commented Nov 10, 2023

@mishabruml you can now use v2.23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants