Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix uds.Write error check leading to unneeded re-connection #115

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix uds.Write error check leading to unneeded re-connection #115

merged 1 commit into from
Dec 13, 2019

Conversation

arbll
Copy link
Member

@arbll arbll commented Dec 13, 2019

What does this PR do ?

A nil error check was missing in udsWriter.Write leading to unneeded re-connections.

Motivation

This added significant overhead to the Write method.

@arbll arbll added the bug label Dec 13, 2019
@arbll arbll merged commit a33ed78 into master Dec 13, 2019
@arbll arbll deleted the arbll/nil-check branch December 13, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwbrown derekwbrown derekwbrown approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arbll @derekwbrown