Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option to disable telemetry, document available metrics #117

Merged
merged 9 commits into from
Jan 6, 2020
Merged

add an option to disable telemetry, document available metrics #117

merged 9 commits into from
Jan 6, 2020

Conversation

arbll
Copy link
Member

@arbll arbll commented Dec 16, 2019

Fixes #114

@arbll arbll requested a review from a team as a code owner December 16, 2019 11:09
cswatt
cswatt requested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@CodyPubNub CodyPubNub mentioned this pull request Dec 16, 2019
Closed
wenwei63029869
wenwei63029869 reviewed Dec 16, 2019
View reviewed changes
statsd/options.go Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Dec 17, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
arbll and others added 4 commits December 17, 2019 12:13
@arbll @cswatt
Update README.md
12f9fab 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@arbll @cswatt
Update README.md
30669bc 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@arbll
typo: en=>of
f621199
@arbll
Update README.md
9123bc2
@arbll arbll requested review from cswatt and l0k0ms December 17, 2019 11:25
truthbk
truthbk approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@arbll arbll merged commit 4ed8952 into master Jan 6, 2020
@arbll arbll deleted the arbll/telemetry-option branch January 6, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenwei63029869 wenwei63029869 wenwei63029869 left review comments

@truthbk truthbk truthbk approved these changes

@cswatt cswatt Awaiting requested review from cswatt

@l0k0ms l0k0ms Awaiting requested review from l0k0ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry added in PR #91 is unable to be disabled
5 participants
@arbll @truthbk @cswatt @l0k0ms @wenwei63029869