Add support for DD_ENV, DD_SERVICE, and DD_VERSION environment variables #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
requested changes
Mar 10, 2020
jdgumz
changed the title
hush-hush
requested changes
Mar 11, 2020
statsd/statsd.go
Outdated
Comment on lines
294
to
300
| parts := strings.Split(tag, ":") | ||
| if len(parts) == 1 { | ||
| c.Tags = append(c.Tags, parts[0]) | ||
| } | ||
| if len(parts) == 2 { | ||
| c.Tags = append(c.Tags, fmt.Sprintf("%s:%s", parts[0], parts[1])) | ||
| } |
There was a problem hiding this comment.
Why split ? What is the value of a tag contains : ?
There was a problem hiding this comment.
Good call, we do support : in tag values.
I've updated the logic and test cases accordingly.
jdgumz
changed the title
… for env, service, and version
jdgumz
force-pushed
the
jesse.gumz/add-support-for-dd-env-service-version-as-global-tags
branch
from
88e94f5
to
9d27212
Compare
jdgumz
changed the title
hush-hush
requested changes
Mar 12, 2020
statsd/statsd.go
Outdated
Comment on lines
86
to
88
| // Client-side entity ID injection for container tagging | ||
| /* | ||
| Client-side entity ID injection for container tagging. | ||
| */ |
There was a problem hiding this comment.
No need to change the comment
statsd/statsd.go
Outdated
Comment on lines
89
to
92
| const ( | ||
| entityIDEnvName = "DD_ENTITY_ID" | ||
| entityIDTagName = "dd.internal.entity_id" | ||
| ) |
There was a problem hiding this comment.
I don't think we need to keep those variables around, we could hardcode them in the ddEnvTagsMapping like the other ones.
hush-hush
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
DD_ENVDD_SERVICEDD_VERSIONto be used by the statsd client at initialization. The first three are added as global tags for
{env, service, version}, if they are set.