Add UDS support #37
Add UDS support #37
Conversation
statsd/statsd.go
Outdated
| UDSTimeout holds the default timeout for UDS socket writes, as they can get | ||
| blocking when the receiving buffer is full. | ||
| */ | ||
| const DefaultUDSTimeout = 1 * time.Millisecond |
statsd/statsd.go
Outdated
| conn net.Conn | ||
| // function pointer to use to write data to the connection | ||
| write func([]byte) error |
There was a problem hiding this comment.
🍰
If we export Although we might also want precisely the opposite to prevent the users from writing directly to the socket - yeah, I think we don't want to export Write :)Write, Client would implement the Writer interface, which might be desireable (I'm not sure just a thought).
What we could do to maybe do is have this be an interface to io.Writer.
type Client struct {
...
sock io.Writer,
...
}
And have two different structs, one for UDP and one for UDS, both implementing Writer. We can assign the right one during the creation of the Client. Should be straight-forward, but let me know if I'm missing something.
You could then do cli.sock.Write([]byte) in the remaining code.
It's tremendously similar to what you're already doing, so it may be overkill. But it would perhaps give us some flexibility for the future.
statsd/statsd.go
Outdated
| c.writeTimeout = d | ||
| return nil | ||
| } else { | ||
| return errors.New("SetWriteTimeout: only supported for UDS connexions") |
There was a problem hiding this comment.
tiny typo: connexions -> connections
| // A statsdWriter offers a standard interface regardless of the underlying | ||
| // protocol. For now UDS and UPD writers are available. | ||
| type statsdWriter interface { | ||
| Write(data []byte) error |
Add Unix Domain Socket support, as implemented in DSD6.
Protocol and error handling follows the specs at https://github.com/DataDog/datadog-agent/wiki/Unix-Domain-Sockets-support
Documentation will be updated once code is OK.