Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting eventAlertType and eventPriority types #42

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

thomas91310
Copy link
Contributor

@thomas91310 thomas91310 commented Oct 18, 2017

I am "code complete" but wanted to give some more information on:

  • how I am testing this
  • how I am using these exported types in my code

I don't think the code will change though...
So, while I'm adding these 2 things, any questions/concerns on the code change?

@masci

(cc. @dm03514)

@masci
Copy link
Contributor

masci commented Oct 19, 2017

LGTM! Waiting for you to add those info but so far so good

@thomas91310
Copy link
Contributor Author

thomas91310 commented Oct 20, 2017

@masci

I just uploaded the package I am using to send events to DataDog: https://github.com/thomas91310/dd-stats/

How I am using the exported statsd.EventAlertType and statsd.EventPriority types:

I, here, imported my fork and implemented these two test calls to SendEvent.
You can see the exported types exposed to the caller of the method here.

How I QA'd:

I started this udp test server on a separate tab.
Executing this main against this udp-test-server resulted in this output.txt file

Let me know if you have questions!

Thanks,
Thomas

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your detailed explanation and the examples provided.

@masci masci added this to the 1.2.0 milestone Oct 20, 2017
@masci masci merged commit 2a3d87e into DataDog:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants