Implemented support for ServiceChecks #5
Conversation
|
@jovanbrakus sorry for the slow response, I realize you sbumitted this ages ago! We'll review this very shortly, thanks a lot for your patience! 👍 |
|
I stumbled upon the fact that event texts as well as service check messages can contain |
|
Yup, agreed. |
|
Just a quick note, #8 has now been merged. |
|
I added escaping of '\n' and 'm:' along with tests that show functionality... |
|
@jovanbrakus could you please rebase to the latest master? |
| @@ -266,6 +266,76 @@ func TestEvents(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestServiceChecks(t *testing.T) { | |||
There was a problem hiding this comment.
Thank you so much for writing this! ❤️
|
Looks solid, if you could please add the unicode message test, rebase and squash, we should then be good to merge! Thanks so much for your contrib! |
…1500) it should be 1432
…t. FLush what we commited. [udp] lets return a slice of frames to flush. [udp] fixing tests to meet new logic. [udp] max payload should be const. [datadog-go] improving tests for udp splitting.
|
Added unicode test and rebased it to latest master. |
|
@jovanbrakus I think you accidentally rebased on the wrong branch or branched off the wrong one, so we've got a few conflicts... Anyways I created a branch (jaime/svchk_support @ https://github.com/DataDog/datadog-go/compare/jaime/svchk_support) with your commits and no conflicts, if you want to |
|
Haven't seen your msg before.... Branch svchk_support looks fine. |
|
hi guys any chance this might get merged soon? we'd really like to use this functionality. Please :) |
|
We're using ServiceChecks in production for months... but we would also like to have it merged in. |
|
Closing this as it's been merged on another PR |
Support for ServiceChecks is implemented based on DataDog wire protocol specification.