configuration at client creation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
reviewed
Mar 23, 2019
| } | ||
|
|
||
| // Option is a client option. Can return an error if validation fails. | ||
| type Option func(*Options) error |
statsd/options.go
Outdated
| // DefaultMaxMessagesPerPayload is the default value for the MaxMessagesPerPayload option | ||
| DefaultMaxMessagesPerPayload = 16 | ||
| // DefaultBlockingUDS is the default value for the BlockingUDS option | ||
| DefaultBlockingUDS = false |
There was a problem hiding this comment.
Blocking UDS the default behavior earlier, so this would change the behavior for customer clients possibly unwillingly. I personally would love the gains, but maybe the buffered UDS sender should be an opt-in feature?
There was a problem hiding this comment.
Let's keep blocking in 2.x
statsd/options.go
Outdated
| } | ||
|
|
||
| // BlockingUDS sets the BlockingUDS option. | ||
| func BlockingUDS() Option { |
There was a problem hiding this comment.
WithBlockingUDS for consistency, perhaps?
truthbk
pushed a commit
that referenced
this pull request
Apr 5, 2019
* move old uds writer to uds blocking * add async implementation * refactor tests * remove some useless code in ensureConnection * add comment about write thread safety * configuration at client creation (#82) * introduce options * configuration at client creation * remove EOL'd go versions from testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR adds a generic way to deal with the client configuration. I decided to use function options here for the implementation. This is discussable and definitely has it's pro and cons. However I prefer it over it's alternative, using a configuration struct, since it allows for dumb default value logic while using a struct would add quite a bit of complexity dealing with Golang zero values. I'm happy to discuss if someone has an opinion here.
Motivation
The list of options is growing and some new ones require to be known at the client creation. Creating new constructors like
NewBufferedis not scalable.Allowing options to be mutable after the client creation isn't a very good practice IMO.