Fix dictionary changed size during iteration #142 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing the issue @leozc 🙇 . We'll merge your contribution very shortly. |
| @@ -139,7 +139,7 @@ def add_point(self, metric, tags, timestamp, value, metric_class, sample_rate=1, | |||
| def flush(self, timestamp): | |||
| """ Flush all metrics up to the given timestamp. """ | |||
| interval = timestamp - timestamp % self._roll_up_interval | |||
| past_intervals = [i for i in self._metrics if i < interval] | |||
| past_intervals = [i for i in list(self._metrics.keys()) if i < interval] | |||
There was a problem hiding this comment.
self._metrics.keys() already creates a copy of self._metrics keys. Let's remove the extra list(...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy the key to a list before iterating to prevent the error.
It is less performance since keys were copied, and there should be better approaches