Force integer division for truncation of stdout/stderr in dogwrap #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢
Observed behaviour:
When
dogwrap
runs in a Python 3 environment withsubmit_mode=all
, and there is bothstdout
andstderr
, the following error occurred:Cause:
This is because in Python 3,
int / int
no longer returns an int, it returns a float. And floats are invalid index values.Solution:
This integer division functionality can be forced by using
//
rather than/
in both Python 3 and Python 2. (Tested in Python 2.7.12, Python 3.5.2; operator introduced in Python 2.2+ (PEP238)This change has only been tested manually, because it doesn't appear
dogwrap
is currently being tested (please correct me if I'm wrong)