Append all statsd client level tags to status checks. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallbrekka
force-pushed
the
marshall/service-check-constant-tags
branch
4 times, most recently
from
3993455
to
9e24b09
Compare
This makes the python statsd client behavior consistent with the ruby and golang statsd clients, which also include the client level tags on service checks.
marshallbrekka
force-pushed
the
marshall/service-check-constant-tags
branch
from
9e24b09
to
b40f5df
Compare
|
Looks great to me. Thanks for making the change 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the python statsd client behavior consistent with the ruby and
golang statsd clients, which also include the client level tags on service
checks.