Add monitor and monitor groups search API endpoints #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athap
reviewed
Oct 15, 2018
yannmh
reviewed
Oct 15, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| CHANGELOG | |||
| ========= | |||
| # 0.23.0 / 2018-10-13 | |||
There was a problem hiding this comment.
Can you change the date to "Unreleased" for now? We generally set it after the pypi package is released
datadog/api/monitors.py
Outdated
| @classmethod | ||
| def search_monitor_groups(cls, **params): | ||
| """ | ||
| Search monitor monitor groups |
There was a problem hiding this comment.
We generally avoid repeating the resource name in the method (for example api.Monitor.get instead of api.Monitor.get_monitor). For this reason, I think it'd be more consistent to rename both methods search and search_groups. What do you think?
yannmh
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds monitor search and monitor groups search API endpoints.
Docs:
https://docs.datadoghq.com/api/?lang=python#monitors-search
https://docs.datadoghq.com/api/?lang=python#monitors-group-search