Allow listing timeboards with empty descriptions #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_escape()` method assumed it always would be receiving a string, but if there is no description set on a timeboard it would instead be set to `None`. This handles those cases by instead making the function return an empty string in case the input is False-y - ie. `None`.
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
The `_escape()` method assumed it always would be receiving a string, but if there is no description set on a timeboard it would instead be set to `None`. This handles those cases by instead making the function return an empty string in case the input is False-y - ie. `None`.
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
The `_escape()` method assumed it always would be receiving a string, but if there is no description set on a timeboard it would instead be set to `None`. This handles those cases by instead making the function return an empty string in case the input is False-y - ie. `None`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_escape()method assumed it always would be receiving a string, but ifthere is no description set on a timeboard it would instead be set to
None.This handles those cases by instead making the function return an empty string
in case the input is False-y - ie.
None.