Use headers only #446
Merged
Use headers only #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bkabrda
previously requested changes
Sep 26, 2019
There was a problem hiding this comment.
I'm seeing a lot of integration test failures that I haven't seen without this PR. Specifically:
- Any integration tests that try to send metrics fail with 403.
- Any integration tests that try to create events fail with 403.
- Any integration tests that try to post service check statuses fail with 403.
Have these API endpoints been adapted to respect the headers? If not, they'll need to be before we can accept this PR (alternatively we would need to differentiate which endpoint the HTTP request is being sent to and based on that we'd need to add headers or query params)
|
/azp run |
|
/azp run DataDog.datadogpy.integration |
|
/azp run |
|
Comment was made before the most recent commit for PR 446 in repo DataDog/datadogpy |
1 similar comment
|
Comment was made before the most recent commit for PR 446 in repo DataDog/datadogpy |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
* Use headers only * Check if api_key is required in params for some endpoints * Add unit test for api_keys in params * Fix blank lines * Remove more spaces * Add a set of excluded paths * flake * flake8 * Flake8 on another file
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* Use headers only * Check if api_key is required in params for some endpoints * Add unit test for api_keys in params * Fix blank lines * Remove more spaces * Add a set of excluded paths * flake * flake8 * Flake8 on another file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog now accepts api and app keys in headers. This PR modified datadogpy to pass api and app keys in headers only.