Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres locks per mode and thing locked #1019

Merged
merged 6 commits into from
Aug 29, 2014
Merged

Postgres locks per mode and thing locked #1019

merged 6 commits into from
Aug 29, 2014

Conversation

alq666
Copy link
Member

@alq666 alq666 commented Jul 6, 2014

From #1009

@alq666
Update copyright
d7ad2c8
@alq666
Gather lock counts for the current db
7d6b899 
Tag with lock mode and table name (though indices will show up here
as well).
@remh
Copy link
Contributor

remh commented Jul 7, 2014

I guess it's also available on older versions of postgres ?

@alq666
Copy link
Member Author

alq666 commented Jul 8, 2014

A fair question. I will check.
On Jul 7, 2014 5:16 PM, "Remi Hakim" notifications@github.com wrote:

I guess it's also available on older versions of postgres ?

—
Reply to this email directly or view it on GitHub
#1019 (comment).

@remh remh added this to the 5.0 milestone Jul 10, 2014
@remh
Copy link
Contributor

remh commented Jul 15, 2014

Any update on that ?

@remh remh added the 1 - Ready label Jul 17, 2014
@remh remh modified the milestones: 5.1.0, 5.0 Jul 23, 2014
@miketheman
Copy link
Contributor

background writer was introduced in postgres 8.3 (ref)

pg_locks table dates back to at least 7.4 (ref)

Looks like this PR might be need a rebase?

@alq666
Merge from master
372a37f 
Conflicts:
	checks.d/postgres.py
@alq666
Add a test for bgwriter and lock collection
6139fb4
@alq666
Update tests with new bgwriter stats.
266fa8b 
Locks require scaffolding to test. May consider afterwards
@alq666
Copy link
Member Author

alq666 commented Aug 29, 2014

Failing because of mongo, not postgres.

alq666 added a commit that referenced this pull request Aug 29, 2014
@alq666
Merge pull request #1019 from DataDog/alq/pg-locks
4cca2f7 
Postgres locks per mode and thing locked
@alq666 alq666 merged commit 4cca2f7 into master Aug 29, 2014
@remh
Copy link
Contributor

remh commented Aug 29, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remh remh

Labels
1 - Ready
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alq666 @remh @miketheman