Added some features to the directory check #1041
Conversation
Added configuration params to change the tag names (directory and file)
|
Hi @Osterjour thanks for your contribution! You can't add an individual tag for each file as it would create different histograms from each of these files. Hence, these histograms will be only computed with a single data point and will be meaningless. Another issue that tagging by file could raise is the fact that it could potentially create too many contexts for those metrics (let's say you have a directory with 10000 files). Does it make sense ? And thanks again for your contribution! |
|
Hi @remh, thanks for your message. What do you think? Bests, |
|
Yes that could be an option. However you'd need to add some safeguards to prevent from using that option with a directory that has too many files as it could really collect too much data. |
…ture (default False to make sure we don't change the known behaviour) - User needs to decide now if he wants the gauges OR the histogram of the whole directory - Added a hard coded limitation of 20 files per directory (to limit the data)
|
What do you think of the latest changes, @remh? |
|
Yes it looks better! |
Added some features to the directory check
Added an individual tag for each file which matched the pattern
Added configuration params to change the tag names (directory and file)