add logging of serverStatus errors #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code does not check if db.serverStatus() returns an error (e.g. insufficient privileges). If that is the case, no message is logged anywhere, so user has no clue why metrics are not being posted. I propose to log a warning with the error message.
|
Thanks a lot @igroenewold ! The master branch is now frozen until release of Agent 5.0.0. We'll review and merge for the next release. |
|
Thanks! |
remh
added a commit
that referenced
this pull request
Aug 29, 2014
add logging of serverStatus errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code does not check if db.serverStatus() returns an error (e.g. insufficient privileges). If that is the case, no message is logged anywhere, so user has no clue why metrics are not being posted. I propose to log a warning with the error message.