Batch raw OID retrieval to bypass 'tooBig' SNMP error #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to poll about 40 OIDs at the same time we got an SNMP 'tooBig' error and no stats were exported at all. One can change the size limit in the server's SNMP configuration but it can be done only so much. This is a bit naive approach to fix it which seems to be working.
|
That's interesting @bpuzon, thanks for reporting this! We'll review your code and include your contribution in a future version of the SNMP check. |
|
They were SNMP stats exported by a fork of MongooseIM. |
| for table_row in all_binds: | ||
| for result_oid, value in table_row: | ||
| if lookup_names: | ||
| object = result_oid.getMibSymbol() |
There was a problem hiding this comment.
Can you rename this variable while you're at it ? We shouldn't override python function names: https://docs.python.org/2/library/functions.html?highlight=object#object
Thanks!
|
Thanks it looks good beside the recommendation about variable name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to poll about 40 OIDs at the same time we got
an SNMP 'tooBig' error and no stats were exported at all.
One can change the size limit in the server's SNMP configuration
but it can be done only so much.
This is a bit naive approach to fix it which seems to be working.