Only collect relevant Docker metrics by default #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add collect_all_metrics option to collect all the others
| @@ -210,8 +211,8 @@ def _report_containers_metrics(self, containers, instance): | |||
| stat_file = self._get_cgroup_file(cgroup["cgroup"], container['Id'], cgroup['file']) | |||
| stats = self._parse_cgroup_file(stat_file) | |||
| if stats: | |||
| for key, (dd_key, metric_type) in cgroup['metrics'].items(): | |||
| if key in stats: | |||
| for key, (dd_key, metric_type, common_metric) in cgroup['metrics'].items(): | |||
There was a problem hiding this comment.
Nitpick but iteritems would be better.
There was a problem hiding this comment.
Absolutely right!
|
Looks good beside the tiny nitpick! |
|
👍 💥 |
remh
added a commit
that referenced
this pull request
Nov 21, 2014
Only collect relevant Docker metrics by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer collect all the memory cgroups metrics by default. Focus on the interesting ones which will be available in default dashboards.
Add
collect_all_metricsoption to collect all the others.