Add etcd support with self and store metrics. #1235
Conversation
|
Hi @gphat, thanks a lot for your contribution! |
|
Excellent. Thanks @LeoCavaille! |
| default_timeout = self.init_config.get('default_timeout', 5) | ||
| timeout = float(instance.get('timeout', default_timeout)) | ||
|
|
||
| tags = instance_tags |
There was a problem hiding this comment.
This new variable assignment could probably be avoided.
|
I haven't tested this yet. I'll do that tomorrow! Tried to address each of your comments. Thanks! |
|
Okey doke! I believe this has everything we've discussed so far addressed. I have yet to test it, but I'll do that tomorrow. Today was all meetings. :P |
|
Ok, this is working and tested locally. I'm getting metrics and everything looks good! Any more feedback @LeoCavaille? |
| # stdlib | ||
| import time | ||
| from hashlib import md5 | ||
| import urllib2 |
There was a problem hiding this comment.
time, urllib2 and md5 do not seem to be used
|
@gphat looks really good. Thanks a lot for the hard work. I made a last round of comments, mainly inspired by running locally pylint and pep8 on the check. After that it's a go 👍 |
|
Thank you for taking the time to come back and help me improve this each time. Like I said, I totally jacked this from the Mesos check. :) I've made the improvements but I will verify things work tomorrow, since I might've left in runtime problems by editing this on my home computer and not verifying. 😄 |
|
Okay @LeoCavaille! Things work locally and your great feedback has been rolled in. I have only one question which is if we want to somehow escape the URL tag?
|
|
@gphat the tag can be an arbitrary string, so it shouldn't cause any trouble. Do you think of something more sensible to tag instances with? One last thing (maybe because of my comment..) but your service checks should report like service_check_tags = ["url:{}".format(url)]
self.service_check('first', ..., tags=service_check_tags)
self.service_check('second', ..., tags=service_check_tags)the expected named parameter is |
|
Derp. Fixed! Nah, the URL is fine. I just wasn't sure about escaping of tags and how concerned you were about that. |
|
🎅 |
Add etcd support with self and store metrics.
What this patch does
This patch adds a check for etcd. It fetches metrics from etcd's
/v2/metrics/selfand/v2/metrics/store. I ripped most of the code form the existing Mesos check.Motivation
We use etcd in production and would love to have Datadog visibility into it's work. In addition to the various gauges and rates it also turns the 'leader: true` value in to a 1 or 0 and creates a metric. This way we can watch for leadership changes and split brains.
Testing
I'm running this check on a staging machine and seeing metrics!