Add pgbouncer check and tests #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianZaccaria
force-pushed
the
dorian/pgbouncer
branch
from
f569f5d
to
67c519f
Compare
|
@remh Any update for this one? |
|
This one is assigned to me on trello, so I guess I'll take it. |
|
|
||
| class ShouldRestartException(Exception): pass | ||
|
|
||
| class PgBouncer(AgentCheck): |
There was a problem hiding this comment.
nitpick, but should have 2 newlines between (import and class) and (2 classes).
DorianZaccaria
force-pushed
the
dorian/pgbouncer
branch
2 times, most recently
from
c1d8777
to
c99437b
Compare
|
Thanks @LeoCavaille |
|
|
||
| except Exception: | ||
| status = AgentCheck.CRITICAL | ||
| self.service_check('pgbouncer.can_connect', status, tags=service_check_tags) |
There was a problem hiding this comment.
You can maybe pass the exception as the service check message to give an idea of what's wrong.
DorianZaccaria
force-pushed
the
dorian/pgbouncer
branch
5 times, most recently
from
39a0eb5
to
c79b63e
Compare
|
@LeoCavaille This one is ready to go. Let me know if there is something else to update. |
DorianZaccaria
force-pushed
the
dorian/pgbouncer
branch
from
c79b63e
to
fa12041
Compare
- Add psycopg to requirements.txt - Add travis ci pgbouncer build - Add pgbouncer tests _ Add pgbouncer check and a configuration example The metrics aggregated are the pools metrics and the stats metrics. See http://pgbouncer.projects.pgfoundry.org/doc/usage.html for more information
DorianZaccaria
force-pushed
the
dorian/pgbouncer
branch
from
fa12041
to
60da101
Compare
|
Thanks @DorianZaccaria for your work on this one. |
LeoCavaille
added a commit
that referenced
this pull request
Mar 5, 2015
Add pgbouncer check and tests
|
YAY! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.