[Core] Do not use proxy for local connections #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Agent 5.0.0, there should always be a local forwarder running and all payloads should go through it. So we should make sure that we pass the no_proxy environment variable that will be used by requests See: https://github.com/kennethreitz/requests/pull/945 Fix #1514
|
I cleared the proxy env variables i was setting that was making some tests to fail. |
|
Looks good, I'll merge once the CI has run. |
remh
added a commit
that referenced
this pull request
Apr 8, 2015
[Core] Do not use proxy for local connections
|
Changes Unknown when pulling ef3f417 on remh/fix_no_proxy into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Agent 5.0.0, there should always
be a local forwarder running and all payloads
should go through it.
So we should make sure that we pass the no_proxy
environment variable that will be used by requests
See: https://github.com/kennethreitz/requests/pull/945
Fix #1514