[jmxfetch] fix windows bootloop 🐛 #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yannmh
commented
Apr 20, 2015
yannmh
commented
- [Windows] Fix JMXFetch bootloop issue when no JMX integration config is found
- [Linux][OSX] Better management of unexpected exit codes ( != 0)
- [Linux][OSX] [Windows] Limit JMXFetch attempts of restarts to 3
- [Linux][OSX][Windows] Fill a status when JMXFetch could not be launched
The nightly builds are named accordingly.
yannmh
force-pushed
the
yann/is-jmx-enabled-2
branch
2 times, most recently
from
db490e2
to
4d4949e
Compare
| if len(self.jmx_checks) > 0: | ||
| return self._start(self.java_bin_path, self.java_options, self.jmx_checks, | ||
| command, reporter, self.tools_jar_path) | ||
| else: |
There was a problem hiding this comment.
Is that really needed if we exit with a 0 status code ?
There was a problem hiding this comment.
I am not sure to understand your point: we don't necessarily exit with a 0 status code.
yannmh
force-pushed
the
yann/is-jmx-enabled-2
branch
2 times, most recently
from
7945957
to
97c4363
Compare
| Monitor the attached process. | ||
| Restarts when it exits until the limit set is reached. | ||
| """ | ||
| def __init__(self, name, process, max_restarts="inf"): |
There was a problem hiding this comment.
the default shouldn't be +inf it should be a reasonable value, 5 seems good to me.
yannmh
force-pushed
the
yann/is-jmx-enabled-2
branch
from
0877e56
to
06ac2f6
Compare
yannmh
added a commit
that referenced
this pull request
Apr 21, 2015
[jmxfetch] fix windows bootloop 🐛
|
Changes Unknown when pulling 06ac2f6 on yann/is-jmx-enabled-2 into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.