Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Postgresql] logging bug for custom metrics #1633

Closed
wants to merge 1 commit into from

Conversation

orenmazor
Copy link
Contributor

This is actually a combination of two bugs:

  1. If you use custom metrics and one of your queries has too many results, you will discover a typo where we attempt to log to 'self.warning', which is not a thing.
  2. the brackets on that call to self.warning result in attempting to format the function result rather than the parameter.

@LeoCavaille LeoCavaille added this to the 5.4.0 milestone May 20, 2015
@LeoCavaille LeoCavaille self-assigned this May 20, 2015
@LeoCavaille
Copy link
Member

Hey @orenmazor thanks a lot for contributing and catching that.
For 1., the self.warning method actually exists, it's meant to display the warning on the info page and in Datadog.

For 2., you're completely right this is a typo. Also it looks like the CI is failing because you have a flake8 error. You can run rake lint (see also how to setup a dev env) before pushing.

@orenmazor
Copy link
Contributor Author

Fixed! I didnt have flake8 built into vim in this env so I didn't catch that.

makes sense about self.warning. this was a flyby fix on one of my servers that I just caught. not super familiar with dd-agent.

@LeoCavaille
Copy link
Member

@orenmazor thanks, merged in a rebased version as 071d06f in #1634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants