[network] normalize instance_name tags
#1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, can you add a test for that please ? |
yannmh
force-pushed
the
yann/network-instance-tag-mismatch
branch
from
adaeac6
to
73aeaf9
Compare
|
Done |
Add tests for `instance_name` tag normalization. Move and rewrite core/test_service_checks.py' tests to 'checks/integration/test_http_check.py' and 'checks/integration/test_tcp_check.py'.
yannmh
force-pushed
the
yann/network-instance-tag-mismatch
branch
from
73aeaf9
to
0fc675a
Compare
remh
added a commit
that referenced
this pull request
Aug 10, 2015
[network] normalize `instance_name` tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Instance name used to be a part of the check name and hence normalized
on the agent before being sent to Datadog.
As part of changes #1642 which introduced support for custom tags,
instance_nameis now sent as a proper tag.Changes
Normalize it, to avoid mismatch and backward incompatiblity. Fix #1796.
Add tests for
instance_nametag normalization.Move
core/test_service_checks.pytests tochecks/integration/test_http_check.pyandchecks/integration/test_tcp_check.py.